🐛 Set notebook path relative to session manager path

.changeset/tiny-bikes-invite.md

@@ -0,0 +1,6 @@
+---
+"myst-execute": patch
+"myst-cli": patch
+---
+
+Define kernel path relative to server base-path

packages/myst-cli/src/process/mdast.ts

@@ -223,6 +223,7 @@ export async function transformMdast(
   if (execute) {
     const cachePath = path.join(session.buildPath(), 'execute');
     await kernelExecutionTransform(mdast, vfile, {
+      basePath: session.sourcePath(),
       cache: new LocalDiskCache<(IExpressionResult | IOutput[])[]>(cachePath),
       sessionFactory: () => session.jupyterSessionManager(),
       frontmatter: frontmatter,

packages/myst-cli/src/session/types.ts

@@ -17,6 +17,7 @@ export type ISession = {
   log: Logger;
   reload(): ISession;
   clone(): ISession;
+  sourcePath(): string;
   buildPath(): string;
   sitePath(): string;
   contentPath(): string;

packages/myst-execute/src/execute.ts

@@ -259,6 +259,7 @@ function applyComputedOutputsToNodes(
 }
 
 export type Options = {
+  basePath: string;
   cache: ICache<(IExpressionResult | IOutput[])[]>;
   sessionFactory: () => Promise<SessionManager | undefined>;
   frontmatter: PageFrontmatter;
@@ -309,7 +310,7 @@ export async function kernelExecutionTransform(tree: GenericParent, vfile: VFile
     else {
       let sessionConnection: Session.ISessionConnection | undefined;
       const sessionOpts = {
-        path: vfile.path,
+        path: path.relative(opts.basePath, vfile.path),
         type: 'notebook',
         name: path.basename(vfile.path),
         kernel: {

packages/myst-execute/src/manager.ts

@@ -79,13 +79,21 @@ export async function launchJupyterServer(
   const proc = spawn(pythonPath, ['-m', 'jupyter_server', '--ServerApp.root_dir', contentPath]);
 
   const reader = proc.stderr;
+
+  let timerID: ReturnType<typeof setTimeout> | undefined;
   const settings = await new Promise<JupyterServerSettings>((resolve, reject) => {
     // Fail after 20 seconds of nothing happening
-    const id = setTimeout(() => {
-      log.error(`🪐 ${chalk.redBright('Jupyter server did not respond')}\n   ${chalk.dim(url)}`);
+    timerID = setTimeout(() => {
+      log.error(`🪐 ${chalk.redBright('Jupyter server did not respond')}`);
       reject();
     }, 20_000);
 
+    // Fail because process exits
+    proc.on('exit', () => {
+      log.error(`🪐 ${chalk.redBright('Jupyter server did not start')}`);
+      reject();
+    });
+
     reader.on('data', (buf) => {
       const data = buf.toString();
       // Wait for server to declare itself up
@@ -97,9 +105,6 @@ export async function launchJupyterServer(
       // Pull out the match information
       const [, addr, token] = match;
 
-      // Cancel timeout error now
-      clearTimeout(id);
-
       // Resolve the promise
       resolve({
         baseUrl: addr,
@@ -108,7 +113,15 @@ export async function launchJupyterServer(
     });
   }).finally(
     // Don't keep listening to messages
-    () => reader.removeAllListeners('data'),
+    () => {
+      reader.removeAllListeners('data');
+      proc.removeAllListeners('exit');
+
+      // Cancel timeout error now
+      if (timerID !== undefined) {
+        clearTimeout(timerID);
+      }
+    },
   );
 
   // Inform log

packages/myst-execute/tests/run.spec.ts

@@ -78,6 +78,7 @@ casesList.forEach(({ title, cases }) => {
         file.path = path.join(__dirname, 'notebook.ipynb');
 
         await kernelExecutionTransform(before, file, {
+          basePath: __dirname,
           sessionFactory: async () => await sessionManagerFactory.load(),
           cache: noOpCache,
           frontmatter: {