馃搫 Support new-page/page-break tags in tex/typst/docx #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwkoch
commented
Apr 19, 2024
|
|
||
| export function getMetadataTags(node: GenericNode) { | ||
| if (!node.data) return []; | ||
| const tags: string[] = node.data.tags ?? []; |
There was a problem hiding this comment.
These fields can also be defined as tags, e.g.
+++ { "tags": ["page-break"] }
rowanc1
approved these changes
Apr 19, 2024
| @@ -149,7 +150,12 @@ const handlers: Record<string, Handler> = { | |||
| return; | |||
| } | |||
| if (node.visibility === 'remove') return; | |||
| if (node.data?.tags?.includes('no-tex')) return; | |||
| if (metadataTags.includes('no-tex')) return; | |||
There was a problem hiding this comment.
Can we expand this to no-pdf and implement typst (no-typst) while we are here?
|
Addresses #714 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now add
page-breakornew-pageto block metadata to create a new page intex,typst, anddocx:+++ { "new-page": true } # Conclusion My conclusion is on a new page.For typst/docx both
page-breakandnew-pageadd a page break. For tex,page-breakandnew-pageinsert\pagebreakand\newpage, respectively.See #714