馃悰 Always use static links for downloads #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanc1
reviewed
Apr 22, 2024
Co-authored-by: Rowan Cockett <rowanc1@gmail.com>
rowanc1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1135 by scoping the URL rewriting to non-static links.
I think what was happening was that the URL was being re-written as an internal link, but the
staticattribute was causing MyST to try and resolve that re-written link as a static item.This change now prevents rewriting for static items (we'll always want those in the
staticendpoint).I didn't add a test yet - not sure where that should go, would appreciate some pointers.