Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃搻 Replace xref text when using angle brackets #1183

Merged
merged 3 commits into from
May 7, 2024

Conversation

fwkoch
Copy link
Member

@fwkoch fwkoch commented May 7, 2024

If you define a cross-project reference like so [](xref:key#identifier), it will be filled in with relevant text from the target. However, like this <xref:key#identifier>, the text remains "xref:key#identifier"

With this PR, that default text is removed, allowing relevant text to be filled later.

@rowanc1
Copy link
Member

rowanc1 commented May 7, 2024

The format text happened before the transform, it can now happen after. The formatter add places for line breaks in long URLs, and the text no longer matches.

@rowanc1 rowanc1 merged commit 9bd9ec8 into main May 7, 2024
5 checks passed
@rowanc1 rowanc1 deleted the feat/xref-angle-brackets branch May 7, 2024 14:39
Copy link

welcome bot commented May 7, 2024

Congrats on your first merged pull request in this project! 馃帀
congrats

Thank you for contributing, we are very proud of you! 鉂わ笍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants