Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Consistent font size in navigation #156

Merged

Conversation

pradyunsg
Copy link
Member

Toward #144

@choldgraf
Copy link
Member

I think this generally looks good. Though the sidebar feels a little bit cramped now that they're all the same size. I wonder what you think about slightly growing the vertical space between top-level left sidebar sections. So something like:

image

(which I added with this rule)

ul.sidenav_l1 > li {
    margin-bottom: 0.2em;
}

@pradyunsg
Copy link
Member Author

pradyunsg commented Aug 6, 2020

Definitely! Lemme wrap up dinner and I'll add the .2em to the elements. I think we already set margin/padding on list items/some elements, so this should fit right in.

@pradyunsg
Copy link
Member Author

Done!

@pradyunsg pradyunsg changed the title Consistent font size in navigation (left sidebar) 👌 IMPROVE: Consistent font size in navigation Aug 7, 2020
@choldgraf
Copy link
Member

nice - OK I'm gonna merge this, though perhaps these changes will also relate to the conversation in #160 and we can always iterate further

@choldgraf choldgraf merged commit f5fd106 into executablebooks:master Aug 7, 2020
@choldgraf
Copy link
Member

thanks @pradyunsg !! 🎉

@pradyunsg pradyunsg deleted the consistent-font-size-in-navigation branch August 7, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants