Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: Add footnote translations #274

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Jan 18, 2021

Fixes jupyter-book/jupyter-book#223 (comment)

e.g. for language = "fr"

image

@chrisjsewell
Copy link
Member Author

Hi @pnavaro how's this for the footer text?
As you can see from the screenshot above, By, Copyright and Last updated on are translated

@chrisjsewell
Copy link
Member Author

On a side note @choldgraf, when I try to build the docs locally (with tox -e docs-clean) I get:

checking consistency... /Users/chrisjsewell/Documents/GitHub/sphinx-book-theme/docs/reference/blog/post1.md: WARNING: document isn't included in any toctree
/Users/chrisjsewell/Documents/GitHub/sphinx-book-theme/docs/reference/blog/post2.md: WARNING: document isn't included in any toctree

which is "fixed" if I add blogpost: true to those documents front-matter.

weirdly this does not happen when building here on RTD, perhaps some issue with how the relative paths are resolved for blog_post_pattern = "reference/blog/*.md"

@chrisjsewell
Copy link
Member Author

perhaps some issue with how the relative paths are resolved for blog_post_pattern = "reference/blog/*.md"

sunpy/ablog#89

@pnavaro
Copy link

pnavaro commented Jan 19, 2021

Hi @pnavaro how's this for the footer text?
As you can see from the screenshot above, By, Copyright and Last updated on are translated

It does not work for me, everything is well translated in french except the footer. Perhaps it is my installation that is not correct:

Name: jupyter-book
Version: 0.9.1
Name: sphinx-book-theme
Version: 0.0.39

@chrisjsewell
Copy link
Member Author

Oh this is not released yet it's just in this PR at present

@pnavaro
Copy link

pnavaro commented Jan 19, 2021

Oh this is not released yet it's just in this PR at present

Ah OK 😅. Merci!

@chrisjsewell chrisjsewell merged commit 0cd23d9 into master Jan 21, 2021
@chrisjsewell chrisjsewell deleted the footnote-translate branch January 21, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multilingual books
2 participants