Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ NEW: Add logo_only theme option #349

Merged
merged 7 commits into from
Jun 29, 2021

Conversation

djangoliv
Copy link
Contributor

Support for logo_only option.

Regars

@welcome
Copy link

welcome bot commented Jun 24, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@djangoliv djangoliv mentioned this pull request Jun 24, 2021
@choldgraf
Copy link
Member

This looks good to me, with a couple extra requests:

@djangoliv
Copy link
Contributor Author

@choldgraf done:

pre-commit ok:

Check JSON...........................................(no files to check)Skipped
Check Yaml...........................................(no files to check)Skipped
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
flake8...............................................(no files to check)Skipped
black................................................(no files to check)Skipped
check-manifest...........................................................Passed
Compile Web Assets...................................(no files to check)Skipped



docs/configure.md Outdated Show resolved Hide resolved
@choldgraf
Copy link
Member

ahh I figured out what was going on - we needed to update the conf in src/jinja not the one in sphinx_book_theme

@choldgraf
Copy link
Member

caught a little bug in the docs (we need this option provided under html_theme_options). Also added a test. Should be working now

@choldgraf choldgraf changed the title feat: add logo_only theme option ✨ NEW: Add logo_only theme option Jun 29, 2021
@choldgraf choldgraf merged commit 2eeb11e into executablebooks:master Jun 29, 2021
@welcome
Copy link

welcome bot commented Jun 29, 2021

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@choldgraf choldgraf added the enhancement New feature or request label Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants