✨ IMPROVE: improve math styling

[akhmerov]

Closes #345, #272.

I didn't figure out how to set up the dev environment, so the compiled assets aren't updated. I hope CI picks it up.

---

Some motivation:

• Equation label misaligned #345 follows https://stackoverflow.com/a/42147108/2217463
• Reduce the spacing around the display math element. #272 is trickier:
  • There is no selector for an element that is followed by another one, only for a preceding one. That's why I apply a negative top margin to display math that follows a paragraph rather than remove the extra margin from a paragraph.
  • AFAIU 1.15rem margin-bottom of a paragraph seems to be inherited from bootstrap, so I can't use any variable for that.

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

[akhmerov]

Doesn't seem to work on either count :(

[choldgraf]

What was the sticking point for setting up the dev environment?

[akhmerov]

What was the sticking point for setting up the dev environment?

Nothing I couldn't handle, just the sheer the amount of tools that I don't (yet) regularly use to install and learn, compared to the expected amount of changes (I incorrectly expected this to be an easy fix).

It was also not completely clear what it'd take—I'd need to install pre-commit to compile the assets, that would in turn install the EBP pre-commit hook, and that will bring in require some minification tools (?).

[choldgraf]

Are you going off of the instructions on the contributing page?

I think the main thing is just to do:

pip install tox    (installs tox)
tox -e docs-update   (builds the documentation from the local copy)

that should be all you need to do. If you want pre-commit to run when you commit things, then first install pre-commit and do:

pre-commit install

and it'll run from then on

[akhmerov]

Thanks, this worked, and helped me figure out the issues.

[akhmerov]

With modifications (here I added an equation without a label as a check):

---

---

Previously:

---

[welcome]

Congrats on your first merged pull request in this project! 🎉


Thank you for contributing, we are very proud of you! ❤️

[choldgraf]

this looks great - thanks for improving this!