Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE: pydata-sphinx-theme 0.7.2 #429

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Conversation

kousu
Copy link
Contributor

@kousu kousu commented Nov 11, 2021

Fixes #427. and fixes #423 Or..it should..but I'm not sure because #428 makes me think what's in this repo is not making it out to pypi. edit it hasn't, and that's expected: #428 (comment). And this should be unnecessary since the new version is already pinned to ~=0.7.1 which covers 0.7.2 as well.

Fixes executablebooks#427. Or..it should..but I'm not sure because executablebooks#428 makes me think what's in this repo is not making it out to pypi.
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - I'll merge if the tests are happy and will cut a release!

@choldgraf choldgraf changed the title Bump pydata-sphinx-theme UPDATE: pydata-sphinx-theme 0.7.2 Nov 11, 2021
@choldgraf choldgraf merged commit d5feead into executablebooks:master Nov 11, 2021
@welcome
Copy link

welcome bot commented Nov 11, 2021

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@choldgraf
Copy link
Member

many thanks @kousu :-)

@kousu
Copy link
Contributor Author

kousu commented Nov 11, 2021

Oh cool! I like the fish. Thanks for getting to this @choldgraf :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with sphinx 4.3.0 Newer version of pydata-sphinx-theme could be used
2 participants