Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: .bd-sizebar-secondary and .secondary-toggle breakpoint #809

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

sinsong
Copy link
Contributor

@sinsong sinsong commented Jan 14, 2024

My friend find that .bd-sidebar-secondary collapse before .secondary-toggle appear. Which means, viewport width between 1200px (xl breakpoint) and 992px (lg breakpoint), both sidebar and toggle button disappear.

I find that a rule come from pydata-sphinx-theme interact with .bd-sidebar-secondary cause collapse less that 1200px (exactly at 1199.98px). With the breakpoint xl.

So this PR is for synchronize .secondary-toogle button with .bd-sidebar-secondary collapse through align breakpoint to xl.

Copy link

welcome bot commented Jan 14, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@sinsong sinsong changed the title Fix .secondary-toggle breakpoint Fix .bd-sizebar-secondary and .secondary-toggle breakpoint Jan 14, 2024
@agoose77
Copy link
Collaborator

@agoose77 agoose77 merged commit bd60e86 into executablebooks:master Jun 12, 2024
14 of 15 checks passed
@agoose77 agoose77 changed the title Fix .bd-sizebar-secondary and .secondary-toggle breakpoint FIX: .bd-sizebar-secondary and .secondary-toggle breakpoint Jun 12, 2024
@agoose77 agoose77 changed the title FIX: .bd-sizebar-secondary and .secondary-toggle breakpoint FIX: .bd-sizebar-secondary and .secondary-toggle breakpoint Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants