🐛 Fix tab-item label with nested syntax (#135)

Co-authored-by: Chris Sewell <chrisj_sewell@hotmail.com>
executablebooks · May 20, 2024 · be1b85d · be1b85d
1 parent 89aaa26
commit be1b85d
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/docs/snippets/myst/tab-options.txt b/docs/snippets/myst/tab-options.txt
@@ -1,7 +1,7 @@
 ::::{tab-set}
 :class: class-set
 
-:::{tab-item} Label
+:::{tab-item} **Label**
 :name: target
 :selected:
 :class-container: class-container

diff --git a/docs/snippets/rst/tab-options.txt b/docs/snippets/rst/tab-options.txt
@@ -1,7 +1,7 @@
 .. tab-set::
     :class: class-set
 
-    .. tab-item:: Label
+    .. tab-item:: **Label**
         :name: target
         :selected:
         :class-container: class-container

diff --git a/sphinx_design/tabs.py b/sphinx_design/tabs.py
@@ -99,6 +99,7 @@ def run(self) -> list[nodes.Node]:
         textnodes, _ = self.state.inline_text(self.arguments[0], self.lineno)
         tab_label = nodes.rubric(
             self.arguments[0],
+            "",
             *textnodes,
             classes=["sd-tab-label", *self.options.get("class-label", [])],
         )
@@ -255,6 +256,7 @@ def run(self) -> None:
 
                 # create: <label for="id">...</label>
                 label_node = sd_tab_label(
+                    "",
                     "",
                     *tab_label.children,
                     input_id=tab_item_identity,

diff --git a/tests/test_snippets/snippet_post_tab-options.xml b/tests/test_snippets/snippet_post_tab-options.xml
@@ -5,7 +5,8 @@
         <container classes="sd-tab-set class-set" design_component="tab-set" is_div="True">
             <sd_tab_input checked="True" id="sd-tab-item-0" set_id="sd-tab-set-0" type="radio">
             <sd_tab_label classes="sd-tab-label class-label" ids="target" input_id="sd-tab-item-0">
-                Label
+                <strong>
+                    Label
             <container classes="sd-tab-content class-content" design_component="tab-content" is_div="True">
                 <paragraph>
                     Content

diff --git a/tests/test_snippets/snippet_pre_tab-options.xml b/tests/test_snippets/snippet_pre_tab-options.xml
@@ -5,7 +5,8 @@
         <container classes="sd-tab-set class-set" design_component="tab-set" is_div="True">
             <container classes="sd-tab-item class-container" design_component="tab-item" is_div="True" selected="True">
                 <rubric classes="sd-tab-label class-label" ids="target" names="target">
-                    Label
+                    <strong>
+                        Label
                 <container classes="sd-tab-content class-content" design_component="tab-content" is_div="True">
                     <paragraph>
                         Content