Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing width, class-img-top, class-img-bottom options to grid-item-card #115

Merged
merged 2 commits into from
Apr 13, 2023
Merged

fix: Add missing width, class-img-top, class-img-bottom options to grid-item-card #115

merged 2 commits into from
Apr 13, 2023

Conversation

jpmckinney
Copy link
Contributor

@jpmckinney jpmckinney commented Dec 8, 2022 •
edited
Loading

closes #109

Personally I would read from CardDirective.option_spec instead of requiring a maintainer to manually sync option_spec and that other array, but maybe there was a reason for it.

@tkknight tkknight mentioned this pull request Jan 4, 2023
Closed
choldgraf
choldgraf approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me - thanks for spotting this and adding the patch!

@choldgraf choldgraf merged commit 48a836c into executablebooks:main Apr 13, 2023
@jpmckinney jpmckinney deleted the 109-fix-missing-grid-item-card-options branch April 13, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown option "width" for grid-item-card
2 participants
@jpmckinney @choldgraf