👌 Improve specificity of JS function name #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
chrisjsewell
changed the title
chrisjsewell
changed the title
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
|
Congrats on your first merged pull request in this project! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes to fix a namespace issue when a Sphinx project uses both, sphinx-design and sphinx-inline-tabs. Both extensions have quite similar JavaScript functionality, sharing the name of the two functions (
readyandonLabelClick). Given that the JavaScript modules (in both cases) are not protected within a namespace, when using sphinx-inline-tabs (I mean, using.. tab:: <label>from sphinx-inline-tabs) fails to work because sphinx-design'sonLabelClickwas loaded after and itsonLabelClickoverrides the same function from sphinx-inline-tabs. The code from sphinx-inline-tabs seems older, that's why I kindly submit the PR here. Thanks by the way for this great Sphinx extension.