Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: Links in card titles #59

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Conversation

chrisjsewell
Copy link
Member

fixes #28

Sphinx expects that references are within another TextElement (e.g. a paragraph), see: https://github.com/sphinx-doc/sphinx/blob/068f802df90ea790f89319094e407c4d5f6c26ff/sphinx/writers/html5.py#L224

To "simulate" this, we wrap the rendered title nodes within a PassthroughTextElement, which is ignored on visits.

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #59 (bf3df19) into main (93955f5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   88.87%   88.90%   +0.02%     
==========================================
  Files          10       10              
  Lines         908      910       +2     
==========================================
+ Hits          807      809       +2     
  Misses        101      101              
Flag Coverage Δ
pytests 88.90% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sphinx_design/shared.py 58.33% <ø> (ø)
sphinx_design/cards.py 96.77% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93955f5...bf3df19. Read the comment docs.

@chrisjsewell chrisjsewell merged commit f452be7 into main Apr 20, 2022
@chrisjsewell chrisjsewell deleted the fix-link-in-grid-item-head branch April 20, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links are not rendered in card titles
2 participants