Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart & Run All does nothing if kernel hasn't been requested #341

Closed
narrator0 opened this issue Dec 29, 2020 · 1 comment · Fixed by #345
Closed

Restart & Run All does nothing if kernel hasn't been requested #341

narrator0 opened this issue Dec 29, 2020 · 1 comment · Fixed by #345
Labels

Comments

@narrator0
Copy link
Contributor

Describe the bug

If kernel hasn't been requested, Restart and Run All button will change output text to waiting for kernel... and hangs.

To Reproduce

Steps to reproduce the behavior:

  1. Set kernel: false in configuration
  2. Click on Restart and Run All

Expected behavior

Should request kernel first and then run all the cells.

Possible Fix

Removing the kernel check in here should fix the problem since kernel is checked in execute and will automatic request if not found.

@narrator0 narrator0 added the bug label Dec 29, 2020
@welcome
Copy link

welcome bot commented Dec 29, 2020

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant