馃悰 FIX: Should request kernel if needed when restartAndRunAll #345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #341
What is the problem?
When kernel is not requested yet, pressing
Restart and Run All
will hang inWaiting for kernel
forever.What is expected?
Should go ahead and request a kernel and then run all.
What is the fix?
Do not check if kernel exist in
restartAndRunAll()
since it will callexecute()
and that will do the job if a kernel is not there.