Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV,DOC,TST,MNT] Dev docs, testing infrastructure #236

Merged
merged 8 commits into from
Oct 16, 2020

Conversation

minrk
Copy link
Collaborator

@minrk minrk commented Aug 13, 2020

  • add release steps to contributing docs
  • develop entrypoint for manual testing (serve file and build:watch)
  • add karma scaffolding for tests and github action
  • publish npm package from github action (can't test without making a release)

towards #233

@choldgraf
Copy link
Member

amazing, thanks! (note it's still in draft, even though the boxes are checked, so I'm not sure if you're done or not...)

@minrk minrk mentioned this pull request Aug 14, 2020
@minrk
Copy link
Collaborator Author

minrk commented Aug 14, 2020

Still draft since I didn't know if the actions worked yet. I'll try to add a few 'real' tests. What I have so far is basically "Can I even build a test????"

@choldgraf
Copy link
Member

choldgraf commented Aug 14, 2020

:-) well FWIW I am a big fan of "something is better than nothing"! Also, the more time that passes the higher likelihood I will fall into baby-land and not be able to press the green button, so FWIW you should go for it whenever you think it's ready! I think this is an important step to growing the dev community around this! e.g. I think @phaustin and some folks at UBC are interested in helping out :-)

@phaustin
Copy link

For sure, no idea what karma scaffolding is, but I'm confident we can find someone who is pure of heart

@minrk minrk marked this pull request as ready for review October 16, 2020 11:37
@minrk
Copy link
Collaborator Author

minrk commented Oct 16, 2020

Going to land this one as a good starting point, at least

@minrk minrk merged commit a0fa3fb into executablebooks:master Oct 16, 2020
@minrk minrk deleted the dev-docs branch October 16, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants