Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should validation check all rules collecting all errors? #55

Closed
niallmccullagh opened this issue Nov 23, 2018 · 2 comments
Closed

Should validation check all rules collecting all errors? #55

niallmccullagh opened this issue Nov 23, 2018 · 2 comments

Comments

@niallmccullagh
Copy link
Contributor

@jwalton What's the best way of returning all the errors when validating the request body. It feels like bad user experience to not respond with all the information available.

Would it be ok to just set allErrors: true in the ajv options by default?
@jwalton
Copy link
Contributor

jwalton commented Nov 26, 2018

Yeah, that sounds fine to me. :)

niallmccullagh added a commit to niallmccullagh/exegesis that referenced this issue Nov 29, 2018
@niallmccullagh
feat: 🎸 Return all errors from body validation
a82985e 
Return all the errors in the request body giving developers more
detailed feedback on the validity of their request

Issues: Closes exegesis-js#55
@niallmccullagh niallmccullagh mentioned this issue Nov 29, 2018
Merged
jwalton added a commit that referenced this issue Nov 29, 2018
@jwalton
feat: Make allErrors an optional flag.
d66784f 
re #55
@jwalton
Copy link
Contributor

jwalton commented Nov 29, 2018

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niallmccullagh @jwalton