Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling different sensors values, change the background to white #125

Closed
jcconca opened this issue Oct 26, 2020 · 7 comments
Closed

Enabling different sensors values, change the background to white #125

jcconca opened this issue Oct 26, 2020 · 7 comments
Labels
help wanted Extra attention is needed Need to be fixed Need to be fixed
Projects

Comments

@jcconca
Copy link
Contributor

jcconca commented Oct 26, 2020

In some cases, enabling sensors to be visualised, like "Voltage", make the background of the sensor section white, and imposible to read the value.

See the below screenshots, to more information:
Screenshot 2020-10-26 at 08 35 20

After selecting values in voltage:
Screenshot 2020-10-26 at 08 35 46

@exelban
Copy link
Owner

exelban commented Oct 30, 2020

Hi.

Thanks for reporting. Unfortunately, I do not know why it's happening. There is no any colorizing in code.
Maybe someone could help with this. It's happening randomly on some systems. And I cannot reproduce this behavior.

@exelban
Copy link
Owner

exelban commented Nov 8, 2020

Hi.
I think I know where is the problem. But it requires rewriting the widgets. I already started to do this. Must be ready till the next release.

@entee55
Copy link

entee55 commented Nov 8, 2020

I think this issue is also with dark mode. For example in dark mode the graph background colors change to white. When you have the white option selected in colors, then it is the same as the background color.
Képernyőfotó 2020-11-08 - 22 30 41
Képernyőfotó 2020-11-08 - 22 31 29

@exelban
Copy link
Owner

exelban commented Nov 8, 2020

I think this issue is also with dark mode. For example in dark mode the graph background colors change to white. When you have the white option selected in colors, then it is the same as the background color.
Képernyőfotó 2020-11-08 - 22 30 41
Képernyőfotó 2020-11-08 - 22 31 29

Please, open a separate issue if the problem is not related to this one.
In this case, I don't see any problems at all. You chose a white color option. And what you expect, that it will change to the black?

PS. If you want to have monochrome colors, there is a special one. Called monochrome.

@entee55
Copy link

entee55 commented Nov 8, 2020

I understand your point, I thought the same. I meant, that in this case maybe the problem is with the background color is changing due to dark mode. I just wanted to help this issue. For me it is working as expected.

@exelban
Copy link
Owner

exelban commented Nov 11, 2020

@entee55 hi. Could I ask you to check this build?
To fix this issue, I must rewrite the sensors widget. And as you remember the last time it crashes the app(
I just don't want to repeat that situation (when the app crashes).

Stats.dmg.zip

@exelban exelban moved this from In progress to Waiting for the next release in Roadmap Nov 12, 2020
@exelban exelban moved this from Waiting for the next release to Done in Roadmap Nov 15, 2020
@exelban
Copy link
Owner

exelban commented Nov 15, 2020

Fixed in the last version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Need to be fixed Need to be fixed
Projects
No open projects
Roadmap
  
Done
Development

No branches or pull requests

3 participants