Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensors widget width should be fixed #348

Closed
lfom opened this issue Feb 18, 2021 · 8 comments
Closed

Sensors widget width should be fixed #348

lfom opened this issue Feb 18, 2021 · 8 comments

Comments

@lfom
Copy link

lfom commented Feb 18, 2021

Describe the bug
The change in the width makes the widgets on the left jump around, I think the dev agrees with me that it is not desirable. 😋
Probably two digits for integer part of Voltage and Power, three for temperature and four for the fans are enough (the largest one would make the width fixed, so no complicated logic is needed, I guess).

Quick question: what Unknown was supposed to show? I am running Catalina on an unsupported iMac if it matters.

Thanks a lot for this incredibly good looking and useful app! I was surprised it uses even less memory than my previous favorite app. 😉

Details:

Screen Shot 2021-02-17 at 21 06 54

@exelban
Copy link
Owner

exelban commented Feb 18, 2021

Hi. You see Unknown because iMac12,1 was not on the official support list of Catalina. I will add this model to the list.
Later I will take a look at the first bug.

@exelban
Copy link
Owner

exelban commented Feb 18, 2021

Ok. About fixed width of Sensors module. I'm not sure if it's possible. Because the Sensors widget has a too big range of width. And if the static width must be the max of all possible. It will be too wide.

@lfom
Copy link
Author

lfom commented Feb 18, 2021

@exelban I see... Maybe a minimum of 4 characters, so it works well most of the times (two digits for integer, plus dot, plus one decimal for voltage and power, it should be good enough for temperature as well)? So a total of 4 character (plus padding, if any). Fan RPM is also 4 characters, isn't it?

@exelban
Copy link
Owner

exelban commented Feb 21, 2021

Yes. In theory, it could be 4 characters for value + space + 3 characters for symbols (RPM for fan). So the fixed width must be for 8 characters. Which ok for people who use it only for temperature or another sensor which has a lot of chars. But I'm pretty sure that after this change someone will come and ask to make it smaller because there is too much space when showing only the temperature.

@lfom
Copy link
Author

lfom commented Feb 21, 2021

That's why I suggested the minimum for voltage/power/temp. There is another widget for the fans only, right?
Yeah, I know that there is always someone complaining about a missing option. The best approach IMHO is to have it configurable: maybe a setting to make it fixed with the minimum required width or not.

@exelban
Copy link
Owner

exelban commented Feb 22, 2021

I agree. The widget can have a fixed width If there will be only voltage/power/temp. But #197.
It will not be the settings option for sure.

@rozhl
Copy link

rozhl commented Feb 28, 2021

Also there should be an option to remove the "RPM" to make the occupied space smaller.

@exelban
Copy link
Owner

exelban commented Mar 28, 2021

There is a lot of problem with this widget. And I will not make it fixed width. At least till it will be rewritten. Also, I'm thinking to remove fans from this module. So maybe it will be much easiest to make it with fixed width.

@exelban exelban closed this as completed Mar 28, 2021
exelban added a commit that referenced this issue Apr 29, 2021
… be fixed from now (#348). Also fixed different graphics glitches (#374)
gmcinalli pushed a commit to gmcinalli/stats that referenced this issue Feb 28, 2022
… be fixed from now (exelban#348). Also fixed different graphics glitches (exelban#374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants