Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats 2.5.12 crash #453

Closed
lanthean opened this issue May 3, 2021 · 34 comments
Closed

Stats 2.5.12 crash #453

lanthean opened this issue May 3, 2021 · 34 comments
Labels
bug Something isn't working
Projects
Roadmap

Comments

@lanthean
Copy link

lanthean commented May 3, 2021 •
edited

Describe the bug
New version of Stats (2.5.12) crashes on M1 version of MBA (Macbook Air).
After a few moments after starting the app, it will crash.
I have SSD (R/W, F/U, usage %), RAM, CPU, Temp, Battery and network (U/D) enabled.

Details:

  • Device: Macbook Air 2020 M1
  • MacOS 11.3 (20E232)
  • Application version 2.5.12
 ✔ lanthean@mba ➤ ~/mnt ➤ /Applications/Stats.app/Contents/MacOS/Stats                                  
Error call(READ_KEYINFO): (iokit/common) invalid argument
Error read(): (iokit/common) invalid argument
Error call(READ_KEYINFO): (iokit/common) invalid argument
Error read(): (iokit/common) invalid argument
2021-05-03 14:16:10.393 Stats[27147:7083104] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[2]'
*** First throw call stack:
(
        0   CoreFoundation                      0x000000018a8d3db8 __exceptionPreprocess + 240
        1   libobjc.A.dylib                     0x000000018a5fd0a8 objc_exception_throw + 60
        2   CoreFoundation                      0x000000018a99ebb4 -[__NSCFString characterAtIndex:].cold.1 + 0
        3   CoreFoundation                      0x000000018a9ac97c -[__NSPlaceholderDictionary initWithCapacity:].cold.1 + 0
        4   CoreFoundation                      0x000000018a7dca60 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 320
        5   CoreFoundation                      0x000000018a80e75c -[NSDictionary initWithDictionary:copyItems:] + 408
        6   CoreFoundation                      0x000000018a80e524 -[__NSPlaceholderDictionary initWithDictionary:copyItems:] + 172
        7   CoreText                            0x000000018be79678 _ZN11TAttributes9ApplyFontEPK14__CFDictionaryPK8__CTFontPK11TCharStream7CFRangePPKv + 252
        8   CoreText                            0x000000018be79430 _ZN11TAttributesC2EPK14__CFDictionaryPK11TCharStream7CFRange + 96
        9   CoreText                            0x000000018bdd4bc8 _ZN21TTypesetterAttrString10InitializeEPK20__CFAttributedString + 356
        10  CoreText                            0x000000018bdd48b8 _ZN21TTypesetterAttrStringC2EPK20__CFAttributedStringPK14__CFDictionary + 112
        11  CoreText                            0x000000018bdd4770 CTLineCreateWithAttributedString + 136
        12  UIFoundation                        0x000000018de060b4 -[NSCoreTypesetter _stringDrawingCoreTextEngineWithOriginalString:rect:padding:graphicsContext:forceClipping:attributes:stringDrawingOptions:drawingContext:stringDrawingInterface:] + 1808
        13  UIFoundation                        0x000000018dd4330c __NSStringDrawingEngine + 1964
        14  UIFoundation                        0x000000018dda78e0 -[NSAttributedString(NSExtendedStringDrawing) drawWithRect:options:context:] + 32
        15  ModuleKit                           0x00000001028248e8 block_destroy_helper.11 + 2344
        16  ModuleKit                           0x0000000102824468 block_destroy_helper.11 + 1192
        17  ModuleKit                           0x00000001028245a8 block_destroy_helper.11 + 1512
        18  AppKit                              0x000000018d1a6334 _NSViewDrawRect + 148
        19  AppKit                              0x000000018d8d7400 -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] + 1312
        20  AppKit                              0x000000018d1a5ab4 -[NSView(NSLayerKitGlue) _drawViewBackingLayer:inContext:drawingHandler:] + 676
        21  QuartzCore                          0x0000000190b4b908 -[CALayer renderInContext:] + 1316
        22  QuartzCore                          0x0000000190b4d258 -[CALayer _renderSublayersInContext:] + 412
        23  QuartzCore                          0x0000000190b4b91c -[CALayer renderInContext:] + 1336
        24  QuartzCore                          0x0000000190b4d258 -[CALayer _renderSublayersInContext:] + 412
        25  QuartzCore                          0x0000000190b4b91c -[CALayer renderInContext:] + 1336
        26  AppKit                              0x000000018d8d6948 -[NSView _renderLayerInContext:] + 288
        27  AppKit                              0x000000018d8d7180 -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] + 672
        28  AppKit                              0x000000018d326380 -[NSView displayRectIgnoringOpacity:inContext:] + 820
        29  AppKit                              0x000000018d325fe8 __62-[NSView cacheDisplayInRect:toBitmapImageRep:includeSubviews:]_block_invoke + 268
        30  AppKit                              0x000000018d325eb8 -[NSBitmapImageRep _captureDrawing:] + 80
        31  AppKit                              0x000000018d325e4c -[NSView cacheDisplayInRect:toBitmapImageRep:includeSubviews:] + 176
        32  AppKit                              0x000000018d7ad5a4 -[NSStatusItem _updateReplicant:] + 1380
        33  AppKit                              0x000000018d2e9d64 -[NSStatusItem _updateReplicants] + 220
        34  AppKit                              0x000000018d7adf50 -[NSStatusItem _updateReplicantsUnlessMenuIsTracking:] + 128
        35  Foundation                          0x000000018b619fe0 __NSFireDelayedPerform + 444
        36  CoreFoundation                      0x000000018a86fdb4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 32
        37  CoreFoundation                      0x000000018a86f9b0 __CFRunLoopDoTimer + 1076
        38  CoreFoundation                      0x000000018a86f438 __CFRunLoopDoTimers + 392
        39  CoreFoundation                      0x000000018a854644 __CFRunLoopRun + 1944
        40  CoreFoundation                      0x000000018a853734 CFRunLoopRunSpecific + 600
        41  HIToolbox                           0x0000000192751b84 RunCurrentEventLoopInMode + 292
        42  HIToolbox                           0x00000001927518f8 ReceiveNextEventCommon + 552
        43  HIToolbox                           0x00000001927516b8 _BlockUntilNextEventMatchingListInModeWithFilter + 72
        44  AppKit                              0x000000018d03d4ec _DPSNextEvent + 836
        45  AppKit                              0x000000018d03be8c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1292
        46  AppKit                              0x000000018d02dd18 -[NSApplication run] + 596
        47  Stats                               0x000000010268fca8 Stats + 15528
        48  libdyld.dylib                       0x000000018a774420 start + 4
)
libc++abi: terminating with uncaught exception of type NSException
[1]    27147 abort      /Applications/Stats.app/Contents/MacOS/Stats
 ✘ lanthean@mba ➤ ~/mnt ➤ uname -a
Darwin mba 20.4.0 Darwin Kernel Version 20.4.0: Fri Mar  5 01:14:02 PST 2021; root:xnu-7195.101.1~3/RELEASE_ARM64_T8101 arm64
 ✔ lanthean@mba ➤ ~/mnt ➤

Command that failed

/Applications/Stats.app/Contents/MacOS/Stats
@exelban
Copy link
Owner

exelban commented May 3, 2021

Hi. Thanks for reporting.
The previous version works fine?

@exelban
Copy link
Owner

exelban commented May 3, 2021

Could I ask to you run the app without a battery module?

@lanthean
Copy link
Author

lanthean commented May 3, 2021 via email •
edited

@exelban
Copy link
Owner

exelban commented May 3, 2021 •
edited

You can download the previous version directly from github.

Strange, there were no changes that can cause this type of crash.

@exelban exelban added the bug Something isn't working label May 4, 2021
@exelban exelban added this to In progress in Roadmap May 4, 2021
@lanthean
Copy link
Author

lanthean commented May 4, 2021 •
edited

Could I ask to you run the app without a battery module?

Sorry for the delay. Just trying. And it only lasts for a little longer before crashing.
Please find below the dump:

 ✔ lanthean@mba ➤ ~ ➤ /Applications/Stats.app/Contents/MacOS/Stats
Error call(READ_KEYINFO): (iokit/common) invalid argument
Error read(): (iokit/common) invalid argument
Error call(READ_KEYINFO): (iokit/common) invalid argument
Error read(): (iokit/common) invalid argument
2021-05-04 10:27:40.120 Stats[96474:7521062] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[2]'
*** First throw call stack:
(
        0   CoreFoundation                      0x000000018a8d3db8 __exceptionPreprocess + 240
        1   libobjc.A.dylib                     0x000000018a5fd0a8 objc_exception_throw + 60
        2   CoreFoundation                      0x000000018a99ebb4 -[__NSCFString characterAtIndex:].cold.1 + 0
        3   CoreFoundation                      0x000000018a9ac97c -[__NSPlaceholderDictionary initWithCapacity:].cold.1 + 0
        4   CoreFoundation                      0x000000018a7dca60 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 320
        5   CoreFoundation                      0x000000018a80e75c -[NSDictionary initWithDictionary:copyItems:] + 408
        6   CoreFoundation                      0x000000018a80e524 -[__NSPlaceholderDictionary initWithDictionary:copyItems:] + 172
        7   CoreText                            0x000000018be79678 _ZN11TAttributes9ApplyFontEPK14__CFDictionaryPK8__CTFontPK11TCharStream7CFRangePPKv + 252
        8   CoreText                            0x000000018be79430 _ZN11TAttributesC2EPK14__CFDictionaryPK11TCharStream7CFRange + 96
        9   CoreText                            0x000000018bdd4bc8 _ZN21TTypesetterAttrString10InitializeEPK20__CFAttributedString + 356
        10  CoreText                            0x000000018bdd48b8 _ZN21TTypesetterAttrStringC2EPK20__CFAttributedStringPK14__CFDictionary + 112
        11  CoreText                            0x000000018bdd4770 CTLineCreateWithAttributedString + 136
        12  UIFoundation                        0x000000018de060b4 -[NSCoreTypesetter _stringDrawingCoreTextEngineWithOriginalString:rect:padding:graphicsContext:forceClipping:attributes:stringDrawingOptions:drawingContext:stringDrawingInterface:] + 1808
        13  UIFoundation                        0x000000018dd4330c __NSStringDrawingEngine + 1964
        14  UIFoundation                        0x000000018dda78e0 -[NSAttributedString(NSExtendedStringDrawing) drawWithRect:options:context:] + 32
        15  ModuleKit                           0x0000000102ee48e8 block_destroy_helper.11 + 2344
        16  ModuleKit                           0x0000000102ee4468 block_destroy_helper.11 + 1192
        17  ModuleKit                           0x0000000102ee45a8 block_destroy_helper.11 + 1512
        18  AppKit                              0x000000018d1a6334 _NSViewDrawRect + 148
        19  AppKit                              0x000000018d8d7400 -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] + 1312
        20  AppKit                              0x000000018d1a5ab4 -[NSView(NSLayerKitGlue) _drawViewBackingLayer:inContext:drawingHandler:] + 676
        21  QuartzCore                          0x0000000190b4b908 -[CALayer renderInContext:] + 1316
        22  QuartzCore                          0x0000000190b4d258 -[CALayer _renderSublayersInContext:] + 412
        23  QuartzCore                          0x0000000190b4b91c -[CALayer renderInContext:] + 1336
        24  QuartzCore                          0x0000000190b4d258 -[CALayer _renderSublayersInContext:] + 412
        25  QuartzCore                          0x0000000190b4b91c -[CALayer renderInContext:] + 1336
        26  AppKit                              0x000000018d8d6948 -[NSView _renderLayerInContext:] + 288
        27  AppKit                              0x000000018d8d7180 -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] + 672
        28  AppKit                              0x000000018d326380 -[NSView displayRectIgnoringOpacity:inContext:] + 820
        29  AppKit                              0x000000018d325fe8 __62-[NSView cacheDisplayInRect:toBitmapImageRep:includeSubviews:]_block_invoke + 268
        30  AppKit                              0x000000018d325eb8 -[NSBitmapImageRep _captureDrawing:] + 80
        31  AppKit                              0x000000018d325e4c -[NSView cacheDisplayInRect:toBitmapImageRep:includeSubviews:] + 176
        32  AppKit                              0x000000018d7ad5a4 -[NSStatusItem _updateReplicant:] + 1380
        33  AppKit                              0x000000018d2e9d64 -[NSStatusItem _updateReplicants] + 220
        34  AppKit                              0x000000018d7adf50 -[NSStatusItem _updateReplicantsUnlessMenuIsTracking:] + 128
        35  Foundation                          0x000000018b619fe0 __NSFireDelayedPerform + 444
        36  CoreFoundation                      0x000000018a86fdb4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 32
        37  CoreFoundation                      0x000000018a86f9b0 __CFRunLoopDoTimer + 1076
        38  CoreFoundation                      0x000000018a86f438 __CFRunLoopDoTimers + 392
        39  CoreFoundation                      0x000000018a854644 __CFRunLoopRun + 1944
        40  CoreFoundation                      0x000000018a853734 CFRunLoopRunSpecific + 600
        41  HIToolbox                           0x0000000192751b84 RunCurrentEventLoopInMode + 292
        42  HIToolbox                           0x00000001927518f8 ReceiveNextEventCommon + 552
        43  HIToolbox                           0x00000001927516b8 _BlockUntilNextEventMatchingListInModeWithFilter + 72
        44  AppKit                              0x000000018d03d4ec _DPSNextEvent + 836
        45  AppKit                              0x000000018d03be8c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1292
        46  AppKit                              0x000000018d02dd18 -[NSApplication run] + 596
        47  Stats                               0x0000000102e4fca8 Stats + 15528
        48  libdyld.dylib                       0x000000018a774420 start + 4
)
libc++abi: terminating with uncaught exception of type NSException
[1]    96474 abort      /Applications/Stats.app/Contents/MacOS/Stats

@exelban
Copy link
Owner

exelban commented May 4, 2021

So, it still crashes with a disabled battery module?

@lanthean
Copy link
Author

lanthean commented May 4, 2021

So, it still crashes with a disabled battery module?

yes

@exelban
Copy link
Owner

exelban commented May 4, 2021

Hmm, does it crash on some action?
Maybe when opening some popup window?
Or settings?

Sorry that I trying to guess. But a crash report just says that there is some internal bug (system). In 99% it causes when trying to calculate the text width. But it does not provide the trace. So there is only one way to find the bug - trying to find a module that causes it. (I don't have m1)

@altrdev
Copy link

altrdev commented May 4, 2021

I tried to reproduce on MBP M1 but I couldn't.
I disabled Battery module, but no issue occurred

@mrchoke
Copy link

mrchoke commented May 4, 2021

Confirmed.
I use macmini M1 it crashed too.

@merken
Copy link

merken commented May 5, 2021

Double confirmed, M1 Macbook Air, same problem

@merken
Copy link

merken commented May 5, 2021

Reverting back to 2.5.11 works.

@lanthean
Copy link
Author

lanthean commented May 5, 2021

Actually no action is needed (on my experience). The 2.5.12 starts and crashes after a little while (e.g. few seconds) - no user actions.
Reverting to 2.5.11 helped - I am having no issue with this version.

@exelban
Copy link
Owner

exelban commented May 5, 2021

Could someone check this build for the crash?
Stats.dmg.zip

@lanthean
Copy link
Author

lanthean commented May 5, 2021

Could someone check this build for the crash?
Stats.dmg.zip

Testing..

@merken
Copy link

merken commented May 5, 2021

Sensors are not displayed in that last custom build:
image

@exelban
Copy link
Owner

exelban commented May 5, 2021

Yes, I know.

@lanthean
Copy link
Author

lanthean commented May 5, 2021

Seems that the custom build is stable. What has changed?

@exelban
Copy link
Owner

exelban commented May 5, 2021

Disabled sensors module.

@exelban
Copy link
Owner

exelban commented May 5, 2021

At least I know in what module bug.

@altrdev
Copy link

altrdev commented May 5, 2021

2.5.12 no issue on MacBook Pro, maybe some edge case (some different sensors maybe?) with Air and Mini?

@exelban
Copy link
Owner

exelban commented May 5, 2021

It related to drawing. It crashes because the string which was drawn a moment ago was cleaned by GC. It's the best what I can understand from the crash. I cannot reproduce this bug. It also happened on intel. So it does not relate to silicon.

@exelban
Copy link
Owner

exelban commented May 5, 2021

Please try this one:
Stats.dmg.zip

@merken
Copy link

merken commented May 5, 2021 •
edited

Thanks, testing it now...
EDIT: Sensors are back :)

@merken
Copy link

merken commented May 5, 2021

Seems to be running fine for the past hour or so...

@exelban
Copy link
Owner

exelban commented May 5, 2021

Hmm, very very interesting. Could I ask someone else who has crash to try the last build?

@exelban exelban mentioned this issue May 5, 2021
Closed
@rajtslegr
Copy link
Contributor

rajtslegr commented May 5, 2021 •
edited

My crash stack after enabling sensors:
stack.txt

EDIT: Removed crash report from comment.

@exelban
Copy link
Owner

exelban commented May 5, 2021 •
edited

@RajceP please check the last posted build.
Could you please remove the crash report from your comment?
It the same problem that all have. And for the future, please post the crash reports in the file. Thanks.

@rajtslegr
Copy link
Contributor

@RajceP please check the last posted build.

No crashes so far.

@exelban exelban mentioned this issue May 5, 2021
Closed
@exelban exelban changed the title Stats 2.5.12 crash on M1 Macbook Air Stats 2.5.12 crash May 5, 2021
@exelban
Copy link
Owner

exelban commented May 5, 2021

Just to ensure. Does the last build crash?

@rajtslegr
Copy link
Contributor

Just to ensure. Does the last build crash?

It does't crash.

@exelban
Copy link
Owner

exelban commented May 5, 2021

Ok, so I can release a fix.
Thanks.

exelban added a commit that referenced this issue May 5, 2021
@exelban
fix: fixed crashes on some macs (#453)
7ce7e38
@exelban exelban closed this as completed May 5, 2021
@exelban exelban moved this from In progress to Done in Roadmap May 5, 2021
@exelban
Copy link
Owner

exelban commented May 5, 2021

I have released a hotfix for this bug.
Thanks everyone for help.

@bttnns
Copy link

bttnns commented May 5, 2021

this hotfix version also fixes my crash on m1 + 2.5.12! Thank you!

@exelban exelban mentioned this issue May 15, 2021
Closed
gmcinalli pushed a commit to gmcinalli/stats that referenced this issue Feb 28, 2022
@exelban @gmcinalli
fix: fixed crashes on some macs (exelban#453)
2b6ffd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Roadmap
  
Done
Milestone
No milestone
Development

No branches or pull requests
7 participants
@merken @bttnns @mrchoke @exelban @altrdev @rajtslegr @lanthean