Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing Translations for zh-Hans #298

Merged
merged 7 commits into from Jan 24, 2021
Merged

Add Missing Translations for zh-Hans #298

merged 7 commits into from Jan 24, 2021

Conversation

Tai-Zhou
Copy link
Contributor

Recently added GPU details are not localized.

@Tai-Zhou
Add Missing Translations
cf356d8 
Update zh-Hans translation.
@exelban
Copy link
Owner

exelban commented Jan 19, 2021

Hi. Thanks.
I have added a translation for the Check for updates option. If you would like, you can translate this as well)

@exelban
Copy link
Owner

exelban commented Jan 23, 2021

Please give to know, when you found a missing phrase in the Localization files. Because it must be added to all localizations, only one. Or (even better) provide the missing phrase to all files.

@Tai-Zhou
Copy link
Contributor Author

Please give to know, when you found a missing phrase in the Localization files. Because it must be added to all localizations, only one. Or (even better) provide the missing phrase to all files.

Maybe I can just fill using English for those languages that I can't speak, sorry for inconvenience.

stats/Stats/Views/Settings.swift

Line 146 in 1f991ee

self.navigationView.addSubview(self.makeButton(2, title: LocalizedString("Support app"), image: "donate", action: #selector(donate)))

BTW, the new commit seems different with the string "Support app" left before.

@exelban
Copy link
Owner

exelban commented Jan 24, 2021

Thanks. Yeap, I miss that (Support app). Will be fixed in the release.
Yes, filling the missing phrases with English will be ok. But please if you doing that split missing phrases and improving translations. It will be easier to figure out that you add something new.

@exelban exelban merged commit 1d3856b into exelban:master Jan 24, 2021
gmcinalli pushed a commit to gmcinalli/stats that referenced this pull request Feb 28, 2022
@Tai-Zhou @gmcinalli
Add Missing Translations for zh-Hans (exelban#298)
2501a46 
* Add Missing Translations

Update zh-Hans translation.

* Update Localizable.strings

Add translation for "Check for updates"

* Update Localizable.strings

Add some missing terms.

* Update Localizable.strings

* Add missing terms and update zh-Hans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tai-Zhou @exelban