Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh icon network #422

Merged
merged 4 commits into from Apr 25, 2021
Merged

Refresh icon network #422

merged 4 commits into from Apr 25, 2021

Conversation

ppizarror
Copy link
Contributor

Captura de Pantalla 2021-04-13 a la(s) 10 24 41

@exelban
Copy link
Owner

exelban commented Apr 17, 2021

Hi. Please open an issue before making a PR with the new feature. It allows discussing if a feature needed at all.
Because in your previous PR you propose to add the translation to the Refresh button. And now, you remove the feature you proposed before with the new one.

@ppizarror
Copy link
Contributor Author

ppizarror commented Apr 17, 2021 •
edited

Ok, I'll create a new issue. Anyway you proposed in the last PR to replace the refresh text into an icon. The refresh translation Is still being used but as a tooltip

@ppizarror ppizarror mentioned this pull request Apr 17, 2021
Closed
@exelban
Copy link
Owner

exelban commented Apr 18, 2021 •
edited

Opening an issue it's a good option before opening a PR, not after.
PR looks fine, but please move the icon to the ModuleKit.

@ppizarror
Copy link
Contributor Author

ppizarror commented Apr 18, 2021 •
edited

Opening an issue it's a good option before opening a PR, not after.
PR looks fine, but please move the icon to the ModuleKit.

yes, I know; my fault as I've plenty of repos, but I'm not used to work in other's people projects, sorry for my mistake

@ppizarror
Copy link
Contributor Author

ppizarror commented Apr 18, 2021 •
edited

I've moved the icon to ModuleKit package 😄

@exelban exelban merged commit 5735691 into exelban:master Apr 25, 2021
gmcinalli pushed a commit to gmcinalli/stats that referenced this pull request Feb 28, 2022
@ppizarror @gmcinalli
feat: add refresh icon to the network (exelban#422)
fa9df5b 
* Added refresh icon to network popup

* Move refresh icon to ModuleKit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppizarror @exelban