Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions workflow for macOS 64-bit #9

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Add Github Actions workflow for macOS 64-bit #9

merged 1 commit into from
Apr 15, 2020

Conversation

PatTheMav
Copy link
Contributor

Important note on this PR: While the GitHub Actions workflow itself succeeds (and artifacts are created for Win32, Win64 and macOS64), the macOS plugin currently crashes OBS at launch. The issue also happens when built from current sources, so it's probably unrelated to the CI build process:

0   libsystem_c.dylib             	0x00007fff6de5ffca __chk_fail_overflow.cold.1 + 16
1   libsystem_c.dylib             	0x00007fff6de5d214 __chk_fail_overflow + 9
2   libsystem_c.dylib             	0x00007fff6de5d848 __memcpy_chk + 18
3   libobs.0.dylib                	0x00000001095fb764 obs_register_source_s + 292
4   move-transition.so            	0x00000000154ec435 obs_module_load + 21
5   libobs.0.dylib                	0x00000001095fa4f3 obs_init_module + 83
6   libobs.0.dylib                	0x00000001095fb380 load_all_callback + 64
7   libobs.0.dylib                	0x00000001095fb299 obs_find_modules + 2153
8   libobs.0.dylib                	0x00000001095faa13 obs_load_all_modules + 35
9   com.obsproject.obs-studio     	0x0000000106dd7a87 OBSBasic::OBSInit() + 775
10  com.obsproject.obs-studio     	0x0000000106db7aab OBSApp::OBSInit() + 491
11  com.obsproject.obs-studio     	0x0000000106dba549 main + 5209
12  libdyld.dylib                 	0x00007fff6dd90cc9 start + 1

Another important note: Without notarization (which would require setting up an Apple Developer account and store certificates as well as account credentials as CI secrets) the package installer will be blocked by default on macOS.

People will need to right-click the .pkg file in Finder and select to "Open" the package installer, then click "Open" again to confirm.

@exeldro
Copy link
Owner

exeldro commented Apr 14, 2020

The check for label 'Seeking Testers' can be removed? The Package step is skipped in the mac build.

@PatTheMav
Copy link
Contributor Author

Removed it already. One missing piece is the file date in the macOS artifact, looking at it right now.

@PatTheMav
Copy link
Contributor Author

@exeldro Artifacts should now be created on every run and I also fixed the file names, so now there are three separate artifacts available for download after a successful run.

@exeldro exeldro merged commit 6cc896f into exeldro:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants