Fixes a couple issues I found with looping and stepping #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: when using the loop single end action and playing the replay in reverse, playback would get stuck in an infinite loop at t=0. By trying to fix this bug, I uncovered some really weird behavior with using the step functionality. With the current changes, playback resumes at the correct spot with no random pauses. I tested this using the different end actions, as well at backwards and forwards playback and stepping past the start and end.
|
pinging @exeldro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: when using the loop single end action and playing the replay in reverse, playback would get stuck in an infinite loop at t=0.
By trying to fix this bug, I uncovered some really weird behavior with using the step functionality. With the current changes, playback resumes at the correct spot with no random pauses. I tested this using the different end actions, as well at backwards and forwards playback and stepping past the start and end.