Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elp keeps images after deleting them #396

Closed
cristinavaldera opened this issue Apr 24, 2019 · 3 comments
Closed

elp keeps images after deleting them #396

cristinavaldera opened this issue Apr 24, 2019 · 3 comments
Assignees
@david-puente
Labels
A Accepted FR

Comments

@cristinavaldera
Copy link
Collaborator

cristinavaldera commented Apr 24, 2019 •
edited by ignaciogros
Loading

When you open an existing elp and delete an existing image, the image keeps on appearing in the folder when exporting as html.

This is important, and it happens with other files too. See #423
@ignaciogros
Copy link
Collaborator

This happens in 2.3.1 and master.

  • Open an elp with images.
  • Delete an image an save.
  • Use the Resources Report option (the image will be there).
  • Export and check that the image is not in any page.

It's important, because the package can get really heavy because of that. It probably happens with other formats too.

@ignaciogros ignaciogros mentioned this issue Jun 24, 2019
Closed
@ignaciogros ignaciogros added A and removed E labels Oct 30, 2019
@ignaciogros
Copy link
Collaborator

ignaciogros commented Oct 30, 2019 •
edited
Loading

We'll apply this solution until the new file manager works:
When trying to add a file that exists (same name with or without the same content), eXe should ask if you want to replace it or upload it with a different name (rename it, just as eXe does right now).
It's not the perfect solution, but at least we'll get smaller packages.

There should be 3 options: Rewrite the existing file | Upload the new file with a different name | Cancel

Important: If you try to use 2 identical files with different names, eXe should not delete one of them (the elp should keep both). @david-puente: Can eXe do that without major changes?

This was referenced Oct 30, 2019
Closed
Closed
JuanPerezSdweb pushed a commit that referenced this issue Nov 22, 2019
@ManuelMayoSdweb
Bug fixes in resource management (#396):
11397f7 
1. - When opening a .elp does not load the resources it does not use.
   1.2 - Opening a .elp does not load duplicate resources.
2. - Deleting a resource from an iDevice removes it.
   2.2 - Removing a resource from an iDevice no longer causes problems
 if other iDevices use that same resource.
3. - Changing a resource manually no longer causes problems.

With these changes, we expect the application's resource management
 to work more consistently.
JuanPerezSdweb pushed a commit that referenced this issue Nov 25, 2019
@ManuelMayoSdweb
Bug fixed in resource management (#396):
5109deb 
- Opening elp with the File Attachment iDevice load resources correctly
@ignaciogros ignaciogros added the FR label Nov 25, 2019
JuanPerezSdweb pushed a commit that referenced this issue Nov 29, 2019
@ManuelMayoSdweb
Revert commit 5109deb
7747833 
"Bug fixed in resource management (#396)"
JuanPerezSdweb pushed a commit that referenced this issue Nov 29, 2019
@ManuelMayoSdweb
Revert commit 11397f7
a759378 
"Bug fixes in resource management (#396)"
JuanPerezSdweb pushed a commit that referenced this issue Dec 12, 2019
@ManuelMayoSdweb
Bug fixes in resource management (#396):
15eea5e 
With these changes, we expect the application's resource management
 works more consistently:

- When opening a .elp does not load the resources it does not use.
- Opening a .elp does not load duplicate resources.
- Deleting a resource from an iDevice removes it.
- Deleting a resource from an iDevice no longer deletes it if it is
  still being used problems.
ManuelMayoSdweb added a commit that referenced this issue Dec 23, 2019
@ManuelMayoSdweb
Bug fixes in resource management (#396):
858d5e7 
With these changes, we expect the application's resource management
 works more consistently:

- When opening a .elp does not load the resources it does not use.
- Opening a .elp does not load duplicate resources.
- Deleting a resource from an iDevice removes it.
- Deleting a resource from an iDevice no longer deletes it if it is
  still being used problems.
@ignaciogros
Copy link
Collaborator

Included in eXe 2.5.

ignaciogros pushed a commit that referenced this issue Aug 15, 2020
@ManuelMayoSdweb @ignaciogros
Bug fixes in resource management (#396):
3ac8033 
With these changes, we expect the application's resource management
 works more consistently:

- When opening a .elp does not load the resources it does not use.
- Opening a .elp does not load duplicate resources.
- Deleting a resource from an iDevice removes it.
- Deleting a resource from an iDevice no longer deletes it if it is
  still being used problems.

# Conflicts:
#	exe/engine/checker.py
@ignaciogros ignaciogros mentioned this issue Nov 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-puente david-puente

Labels
A Accepted FR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ignaciogros @cristinavaldera @david-puente