Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikipedia iDevice. Default article language. #478

Closed
ignaciogros opened this issue Mar 19, 2020 · 0 comments
Closed

Wikipedia iDevice. Default article language. #478

ignaciogros opened this issue Mar 19, 2020 · 0 comments
Assignees

Comments

@ignaciogros
Copy link
Collaborator

If eXe is in Spanish, the default language for a Wikipedia article should be "es" (it's always "en"). That will make the SELECT have this value: http://es.wikipedia.org/wiki/

The problem is that the default value is _('http://en.wikipedia.org/')

That's defined in wikipediaidevice.py, and it is translated (and it's normal) as http://en.wikipedia.org/

Two possible solutions:

  • Handle the error in wikipediablock.py to add "wiki/" after the string.
  • Revise the translations.

I think that handling the error will be enough. I'll commit and close in a minute. Please reopen if you disagree, @jrfern. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants