Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For test failures, should we show the actual and expected values? #105

Closed
glennj opened this issue Oct 12, 2023 · 3 comments · Fixed by #106
Closed

For test failures, should we show the actual and expected values? #105

glennj opened this issue Oct 12, 2023 · 3 comments · Fixed by #106

Comments

@glennj
Copy link
Contributor

glennj commented Oct 12, 2023

With a few small changes to the exercism/test library, we can achieve this.

Some example output:

image

image

image

image

image

@axtens @softmoth
Is it a good idea?
Do you like the output (particularly, opinions about the angle quotes)?

@axtens
Copy link
Member

axtens commented Oct 12, 2023

Chevrons are cool and are used in other places as "really obvious quotation marks". In this PR what's not to like?

@softmoth
Copy link
Contributor

It's great! I can imagine if the expected value is very long, it might be nice to have truncated, but that can be dealt with at a later time if the need crops up.

@axtens
Copy link
Member

axtens commented Oct 13, 2023

Which, when you get to that, should be a middle truncation e.g. tru..ion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants