Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nucleotide Count Exception #70

Closed
timothyrenner opened this issue Sep 1, 2015 · 2 comments
Closed

Nucleotide Count Exception #70

timothyrenner opened this issue Sep 1, 2015 · 2 comments

Comments

@timothyrenner
Copy link
Contributor

In the nucleotide exercise the invalid nucleotide test expects an Exception rather than an AssertionError. Is there a reason for this? It felt odd to use interop to solve the test when a {:pre ...} or assert would suffice.

I'd be happy to PR it, I just think it's worth discussing a bit first, given I'm new-ish to Clojure.
@yurrriq
Copy link
Member

yurrriq commented Sep 1, 2015

This issue has come up several times. Feel free to make a PR and we'll review it.

@timothyrenner
Copy link
Contributor Author

PR is at #71.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurrriq @timothyrenner