Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Parse options insensitive to case, '-' and '_' #79

Closed
ee7 opened this issue Oct 26, 2020 · 0 comments · Fixed by #84
Closed

CLI: Parse options insensitive to case, '-' and '_' #79

ee7 opened this issue Oct 26, 2020 · 0 comments · Fixed by #84
Assignees
@ee7
Labels
kind: feature User-facing enhancement

Comments

@ee7
Copy link
Member

ee7 commented Oct 26, 2020

In #76 (comment) @ee7 wrote:

I was intending to eventually make it style-insensitive anyway. So any of these should be valid:

--probSpecsDir
--probspecsdir
--prob-specs-dir
--prob_specs_dir
--PROBSPECSDIR
--prO_b----sPe____CsDIR

This will allow --prob-specs-dir even if it isn't shown in the --help like that yet.

I'll do this soon.
@ee7 ee7 mentioned this issue Oct 26, 2020
Closed
@ee7 ee7 self-assigned this Oct 26, 2020
ee7 added a commit to ee7/exercism-configlet that referenced this issue Oct 26, 2020
@ee7
Fix(cli): Parse options insensitive to style
37b0aef 
Most importantly, these previously invalid options are now accepted:
    --probspecsdir
    --prob-specs-dir
    --prob_specs_dir
Before this commit, we could only use:
    --probSpecsDir

That is: `--kebab-case` is now supported, even if that fact or
`--prob-specs-dir` itself aren't shown in the `--help` message yet.

Note that we already had case-insensitive parsing for:
  - the values for `mode`
  - the values for `verbosity`
  - arguments (we support `canonical_data_syncer HELP`)

Fixes: exercism#79
@ee7 ee7 mentioned this issue Oct 26, 2020
Merged
ErikSchierboom pushed a commit that referenced this issue Oct 27, 2020
@ee7
Fix(cli): Parse options insensitive to style (#84)
59dca7a 
Most importantly, these previously invalid options are now accepted:
    --probspecsdir
    --prob-specs-dir
    --prob_specs_dir
Before this commit, we could only use:
    --probSpecsDir

That is: `--kebab-case` is now supported, even if that fact or
`--prob-specs-dir` itself aren't shown in the `--help` message yet.

Note that we already had case-insensitive parsing for:
  - the values for `mode`
  - the values for `verbosity`
  - arguments (we support `canonical_data_syncer HELP`)

Fixes: #79
ee7 added a commit to ee7/exercism-configlet that referenced this issue Jan 21, 2021
@ee7
Fix(cli): Parse options insensitive to style (exercism#84)
1865e82 
Most importantly, these previously invalid options are now accepted:
    --probspecsdir
    --prob-specs-dir
    --prob_specs_dir
Before this commit, we could only use:
    --probSpecsDir

That is: `--kebab-case` is now supported, even if that fact or
`--prob-specs-dir` itself aren't shown in the `--help` message yet.

Note that we already had case-insensitive parsing for:
  - the values for `mode`
  - the values for `verbosity`
  - arguments (we support `canonical_data_syncer HELP`)

Fixes: exercism#79
@ee7 ee7 changed the title Fix(cli): Make options insensitive to case, '-' and '_' CLI: Parse options insensitive to case, '-' and '_' May 10, 2021
@ee7 ee7 added the kind: feature User-facing enhancement label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ee7 ee7

Labels
kind: feature User-facing enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix(cli): Parse options insensitive to style ee7/exercism-configlet
1 participant
@ee7