Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fallback font for when FA is disabled #5718

Open
SaschaMann opened this issue Sep 3, 2021 · 5 comments
Open

Add a fallback font for when FA is disabled #5718

SaschaMann opened this issue Sep 3, 2021 · 5 comments

Comments

@SaschaMann
Copy link
Contributor

The icons for formatting in the mentoring editor don't seem to have a fallback font. It's common practice to disable third-party fonts and/or google fonts as part of fingerprinting and tracking protection, so I imagine this will be encountered somewhat frequently.

grafik

@iHiD
Copy link
Member

iHiD commented Sep 3, 2021

Just as an FYI, this is all part of the library, so fixing it will be quite a lot of work.

@SaschaMann
Copy link
Contributor Author

I'd be fine with not having that bar at all in that case. It's a bit weird to have invisible buttons that are even highlighted sometimes.

@iHiD
Copy link
Member

iHiD commented Sep 3, 2021

I'd be fine with not having that bar at all in that case.

Yeah - again, it would the challenge though. We'd have to hack the external library, and I'm not sure that font-detection is something that you can do easily. The app doesn't know whether your call to Google Fonts succeeds or not.

@iHiD
Copy link
Member

iHiD commented Sep 3, 2021

(or in this case font-awesome)

@SleeplessByte
Copy link
Member

The app doesn't know whether your call to Google Fonts succeeds or not.

FontFaceObserver can help us here. See: https://fontfaceobserver.com/

@iHiD iHiD changed the title Mentoring editor icons lack a fallback font Add a fallback font for when FA is disabled May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants