Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing accidental deletion of testimonials #5734

Open
SaschaMann opened this issue Sep 3, 2021 · 5 comments
Open

Preventing accidental deletion of testimonials #5734

SaschaMann opened this issue Sep 3, 2021 · 5 comments

Comments

@SaschaMann
Copy link
Contributor

SaschaMann commented Sep 3, 2021

E.g. by making it red to be consistent with other destructive actions

(The scope of this issue changed, so the title/original message have been adjusted slightly, see the edit history)

@iHiD
Copy link
Member

iHiD commented Sep 3, 2021

(cc @SleeplessByte)

@iHiD
Copy link
Member

iHiD commented Sep 4, 2021

The general argument here is that red can be very alarming for people. And clicking a red button can induce a sense of danger and shame in many people. You shouldn't feel shame at deleting a testimonial (e.g. you might have been misgendered), but you should be heavily warned before deleting your account, so we are trying to only use red buttons in places where the danger outweighs the negatives of the red buttons.

@SaschaMann
Copy link
Contributor Author

That makes sense. If there's some kind of additional confirmation, it's fine if it's not red, I'm just a bit scared of accidentally pressing that.

I suppose if it's the only action in that context menu, it could also be turned into a trash can icon or the likes with a confirmation to reduce the number of clicks when mass-deleting testimonials

@SaschaMann SaschaMann changed the title Delete testimonial should be red Preventing accidental deletion of testimonials better Sep 4, 2021
@SaschaMann SaschaMann changed the title Preventing accidental deletion of testimonials better Preventing accidental deletion of testimonials Sep 4, 2021
@iHiD
Copy link
Member

iHiD commented Sep 4, 2021

Yeah, it'll have a confirmation.

I've generally tried to have everything that opens a confirmation modal have a ... at the end of it (So Delete testimonial...) to make it clear there's a confirmation step. I should do that here.

@SleeplessByte
Copy link
Member

I like the extra stimulus apart from colour given... Not everyone sees colour (the same way).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants