Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] A php-reprensenter #6654

Closed
homersimpsons opened this issue Jan 29, 2023 · 11 comments
Closed

[PHP] A php-reprensenter #6654

homersimpsons opened this issue Jan 29, 2023 · 11 comments

Comments

@homersimpsons
Copy link

I would like to create a representer for PHP.

I did initiate the work in https://github.com/homersimpsons/php-representer and would happily include it in the exercism organization.

I did read the doc carefully, and I have some more questions:

  • The doc says that there could be multiple files in the solutionDir directory, I see that for instance rust-representer only looks for lib.rs. For PHP should I look for only one file (currently I am looking for soltution.php) ?
  • About the representation.json, is it just for the version ?
@github-actions
Copy link

Hi and welcome to Exercism! 👋

We have a community forum which is the correct place to most the majority of requests:

If you are suggesting a new feature or an improvement to Exercism, we also suggest taking a read of this post first.

Unless this issue has been pre-approved (or you are part of the Exercism Team) it will likely be closed without a response. See you in the forum!

@github-actions
Copy link

Hello. Thanks for opening an issue on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this issue has been pre-approved, please link back to this issue on the forum thread and a maintainer or staff member will reopen it.

@homersimpsons
Copy link
Author

For the record I did open an issue on the forum https://forum.exercism.org/t/php-a-php-reprensenter/3178

@ErikSchierboom
Copy link
Member

Thanks for wanting to work on this!

@iHiD Could you create the corresponding repo?

@iHiD
Copy link
Member

iHiD commented Feb 7, 2023

Great :)

@ErikSchierboom
Copy link
Member

@iHiD They were :)

@homersimpsons
Copy link
Author

Thank you for the repository @iHiD

In fact the questions were answered.

I do have some more question though (maybe I should put them in the forum or in a dedicated issue):

  • Is it possible to collect a corpus of solution to run the representer in local ? The goal is to identify possible normalization. I already checked some submitted solution here and there to find potential normalization.
  • Is it possible to collect the nomalization result, or to have an idea on how it behaves ? I know there are some insight in the "Build Status" page, but they are rather high level
  • I see that there are some fsharp tests files, can I freely remove them ? I already designed a similar test suite for the PHP Representer

@ErikSchierboom
Copy link
Member

Is it possible to collect a corpus of solution to run the representer in local ? The goal is to identify possible normalization. I already checked some submitted solution here and there to find potential normalization.

We have the ability to download a corpus of solutions for an exercises via our API. For that, I need to register you as a maintainer. What is your Exercism username?

Is it possible to collect the nomalization result, or to have an idea on how it behaves ? I know there are some insight in the "Build Status" page, but they are rather high level
I'm not entirely sure what you're asking here. The representer should be creating some files, including a representation.txt file which contains the actual representation. We then use that normalization to see if comments are linked to that representation, and if so, use those. We have some docs: https://exercism.org/docs/mentoring/how-to-give-feedback-on-representations and https://exercism.org/docs/building/tooling/representers

I see that there are some fsharp tests files, can I freely remove them ? I already designed a similar test suite for the PHP Representer

Where do you see those?

@homersimpsons
Copy link
Author

We have the ability to download a corpus of solutions for an exercises via our API. For that, I need to register you as a maintainer. What is your Exercism username?

My username is homersimpsons: https://exercism.org/profiles/homersimpsons (care for the extra s at the end)

Where do you see those?

In the following directory: https://github.com/exercism/php-representer/tree/main/tests

@ErikSchierboom
Copy link
Member

My username is homersimpsons: https://exercism.org/profiles/homersimpsons (care for the extra s at the end)

You're now a maintainer in our DB. I've sent you a DM on the forum with the API URL.

In the following directory: https://github.com/exercism/php-representer/tree/main/tests

No idea why they're there! Feel free to remove.

@homersimpsons
Copy link
Author

Thank you @ErikSchierboom I had to update a bit my code to fit the proposed structure. I just pushed a first version for the php-representer.

I confirm I can export the solutions and I will check how the representer behave with those solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants