Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A track that lacks a representer still advertises automated analysis #6703

Open
ee7 opened this issue Sep 13, 2023 · 4 comments
Open

A track that lacks a representer still advertises automated analysis #6703

ee7 opened this issue Sep 13, 2023 · 4 comments

Comments

@ee7
Copy link
Member

ee7 commented Sep 13, 2023

Expected behavior

The track should advertise automatic analysis only when the value of status.representer in the track config.json file is true.

Actual behavior

The track advertises automatic analysis even when the value of status.representer in the track config.json file is false.

Reproduction

  1. In incognito mode, go to https://exercism.org/tracks/go
  2. Notice that it says "with automatic analysis of your code"

1


I mentioned this on the call last Friday. Jeremy said I should ping @ErikSchierboom.

@ErikSchierboom
Copy link
Member

The track should advertise automatic analysis only when the value of status.representer in the track config.json file is true.

I think this should be:

The track should advertise automatic analysis only when the value of status.analyzer or status.representer in the track config.json file is true.

Agree?

@ee7
Copy link
Member Author

ee7 commented Sep 13, 2023

Oh, I guess. You'll know better than me :)

I guess the question is: do we want to say that we perform "analysis" for a solution on a track that only has a representer, but not an analyzer?

I heard about plans to e.g. group solutions that have the same representation, and make things more searchable, which is in some sense "automatic analysis of the code". But I'd guess that we want to only advertise "automatic analysis" for a track that has an analyzer? So your correction sounds good to me.

@ErikSchierboom
Copy link
Member

We do consider representer feedback to be automatic feedback (because it happens, well, automatically :D), so if the track has a representer and/or analyzer enabled, we'll display the message.

@ee7
Copy link
Member Author

ee7 commented Sep 13, 2023

Sounds good to me.

So just to be completely clear: the current behavior is not desired, right? The Go track displays the message, but has neither a representer nor analyzer enabled.

The majority of Exercism tracks currently advertise "automated analysis" even though, as you know, only a small proportion of tracks currently have an enabled representer or analyzer:

#!/usr/bin/env sh
cd dir-containing-every-exercism-track-repo || exit

for dir in */; do
  jq -r 'select(.active and (.status.representer or .status.analyzer)) | .slug' < "${dir}/config.json"
done
bash
clojure
common-lisp
crystal
csharp
elixir
elm
fsharp
java
javascript
php
python
ruby
rust
typescript
wren

But I know that there's an effort to add a generic representer for every track.

Aside: bash is currently the only track that has an analyzer without a representer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants