Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest version of test module in editor #228

Closed
simisc opened this issue Aug 1, 2023 · 0 comments · Fixed by exercism/fortran-test-runner#53
Closed

Use latest version of test module in editor #228

simisc opened this issue Aug 1, 2023 · 0 comments · Fixed by exercism/fortran-test-runner#53

Comments

@simisc
Copy link
Member

simisc commented Aug 1, 2023

This was previously a comment on #227, but I'm moving it to a new issue because I think it's specific to how the test module is made available when testing in the editor.

Changes made to the test module in #226 and #227 are not applied when testing in the editor. When testing an incorrect solution to Sieve, there's still the An error occurred while running your tests. This might mean... message — this is the issue that #227 was intended to solve. For Saddle Points (with correct and incorrect solutions), the message is:

We received the following error when we ran your code:

/tmp/saddle-points/saddle_points_test.f:::

   |     character(MAX_RESULT_STRING_LEN) :: s
      |              
Error: GNU Extension: Symbol max_result_string_len is used before it is typed at ()
/tmp/saddle-points/saddle_points_test.f:::

   |   function pa_to_s(p) result(s)
      |                               
Error: Function result s at () has no IMPLICIT type

This suggests that the editor is using the updated version of saddle_points_test.f90, but not the latest TesterMain.f90. I can reproduce the same error when working locally by using the old TesterMain.f90 with the new saddle_points_test.f90.

When testing an incorrect solution to High Scores in the editor, failed tests are double-counted, so the same issue applies to #226 (i.e., the solution is being tested by the pre-#226 version of the test module).

Originally posted by @simisc in #227 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant