Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booking up for beauty example solution invalid #1232

Open
vaeng opened this issue Feb 27, 2024 · 4 comments
Open

Booking up for beauty example solution invalid #1232

vaeng opened this issue Feb 27, 2024 · 4 comments

Comments

@vaeng
Copy link

vaeng commented Feb 27, 2024

It seems like the implementation for the AM PM string representation has changed.
The current proof solution from the repository does not work with the current test.

The current F# implementation does not use a space any longer between the time and the AM/PM.

|> should equal "You have an appointment on 3/29/2019 3:00:00 PM."

@KyleDickersonComposer
Copy link

KyleDickersonComposer commented Apr 12, 2024

You can pass a date format into the ToString method of DateTime.

Screenshot 2024-04-11 at 10 13 16 PM

@ErikSchierboom
Copy link
Member

There is something weird going on, as the tests have .Replace('\u202F', ' ') appended to them, but they still don't work. Whereas adding .Replace('\u202F', ' ') to the implementation works. I'll have a dig.

@ErikSchierboom
Copy link
Member

I've just upgraded to the latest version of the exercise and now the tests do pass. Could you check that works for you @vaeng?

@vaeng
Copy link
Author

vaeng commented Apr 24, 2024

Sweet. Looks like you've solved the exercise!

@ErikSchierboom Seems to work as intended! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants