Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react: "Callbacks should only be called once even if multiple dependencies have changed" test has expectation on wrong cell #205

Closed
petertseng opened this issue Sep 3, 2016 · 3 comments

Comments

@petertseng
Copy link
Member

After thinking on #187 (comment), I think that c1 should be a c4; it's the only cell with multiple dependencies, and c4 would match the go implementation.

so then you ask, why don't I just fix it myself!

The reason is I think the example solution would not pass that test, and I don't know enough to fix the example solution. So, sorry, I can only file the issue.

@ErikSchierboom
Copy link
Member

Thanks for reporting the issue. I'll look at it soon

@ErikSchierboom
Copy link
Member

@petertseng I can confirm that you have indeed found a bug, it should be c4 instead of c1 in the test you mentioned. I'll work at fixing the example solution.

@ErikSchierboom
Copy link
Member

Fixed with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants