Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions and test case description #2202

Merged
merged 7 commits into from May 17, 2024

Conversation

alexmitchelldev
Copy link
Contributor

Resolves #1818

Updated instructions.md to be less 'technical' and feel more part of the story. I also updated the test case description for the orderFromGrocer function to properly reflect the function name and arguments passed.

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jun 28, 2023
@SleeplessByte SleeplessByte reopened this Aug 24, 2023
@SleeplessByte SleeplessByte self-assigned this Aug 24, 2023
@SleeplessByte SleeplessByte self-requested a review August 24, 2023 17:07
@SleeplessByte
Copy link
Member

(Have not forgotten about this! I'll try to go through this this week <3)

@alexmitchelldev
Copy link
Contributor Author

@SleeplessByte did you ever get chance to take a look at this?

@SleeplessByte
Copy link
Member

@alexmitchelldev apologies. Short explanation at the end of this post https://forum.exercism.org/t/issue-with-local-jest-type-definitions-yarn-3-and-jest/6867/24

@ErikSchierboom @junedev @tejasbubane any of you time to check this?

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could of small suggestions.

exercises/concept/fruit-picker/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/fruit-picker/.docs/instructions.md Outdated Show resolved Hide resolved
alexmitchelldev and others added 5 commits May 16, 2024 03:31
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
@alexmitchelldev
Copy link
Contributor Author

@ErikSchierboom sorry about the glacial response time. I have committed your suggestions.

@ErikSchierboom ErikSchierboom merged commit 0d7bcb1 into exercism:main May 17, 2024
7 checks passed
@ErikSchierboom
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fruit Picker: Improve story/instructions
3 participants