Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protein-translation: slightly confusing setup #1937

Open
ErikSchierboom opened this issue Jun 30, 2024 · 2 comments
Open

protein-translation: slightly confusing setup #1937

ErikSchierboom opened this issue Jun 30, 2024 · 2 comments

Comments

@ErikSchierboom
Copy link
Member

I'm not really sure why the protein-translation exercise has an additional parse function that returns a pub struct CodonsInfo<'a>. It feels a bit weird to me. Maybe a better approach would be to model the codons as an enum?

@senekor
Copy link
Contributor

senekor commented Jun 30, 2024

Looks like the exercise was added in this PR: #603.

There's no discussion on this design descision. It seems to me that it gives students the freedom to prepare the input data for efficient lookup (e.g. hash map), which can then be performed many times. (even though the test suite doesn't do that)

I'm sure the exercise could've been designed a different way, but is it worth it to break existing solutions?

@ErikSchierboom
Copy link
Member Author

I'm sure the exercise could've been designed a different way, but is it worth it to break existing solutions?

I don't think so. I just wanted to discuss some of the design decisions to maybe improve future exercises. I'll post a more detailed reply next week when I'm back at work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants