Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaaS I/O test suit does not account for failing io operations. #992

Open
meltinglava opened this issue Oct 29, 2020 · 5 comments
Open

PaaS I/O test suit does not account for failing io operations. #992

meltinglava opened this issue Oct 29, 2020 · 5 comments
Labels
good first issue An improvement or bug fix that favors new contributors

Comments

@meltinglava
Copy link

The test suit does not inspect what happens on failed IO operation, neither does the task say anything about it. My suggestion would be that we say that we say that you should only log on sucsessful operations.

@meltinglava meltinglava changed the title PaaS I/O test suit unsutable. PaaS I/O test suit does not account for failing io opperations. Oct 29, 2020
@coriolinus coriolinus added the good first issue An improvement or bug fix that favors new contributors label Oct 29, 2020
@coriolinus
Copy link
Member

I'd be happy to review a PR adding that documentation.

@meltinglava
Copy link
Author

I can add the documentation, but the tests does not reflect this. I saw examples of people completing the task with incrementing the amount of reads counters first, then read the bytes, then check for failures and then check update the amount of bytes read. There needs to be a test that makes sure that when an operation fails, the counter and the amounts of bytes read/written as well as the amunts of reads/writs are unchanged.

@coriolinus
Copy link
Member

That's sensible. That test, plus documentation, would be even better than just the documentation.

@ghost ghost changed the title PaaS I/O test suit does not account for failing io opperations. PaaS I/O test suit does not account for failing io operations. Mar 17, 2021
@ayushmishra2005
Copy link

Is someone working on this issue?

@coriolinus
Copy link
Member

Not that I'm aware of. If you want to give it a shot, go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An improvement or bug fix that favors new contributors
Projects
None yet
Development

No branches or pull requests

3 participants