Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stub exercise-name.ts files to each exercise #57

Closed
hoovercj opened this issue Aug 27, 2017 · 5 comments
Closed

Add stub exercise-name.ts files to each exercise #57

hoovercj opened this issue Aug 27, 2017 · 5 comments

Comments

@hoovercj
Copy link

When a user first downloads a typescript exercise they have a directory with a test file that imports a ts file, but that ts file doesn't exist.

For example, 'hello-world.test.ts' imports './hello-world.ts' but there is no stub file.

It is an unnecessary step to require users to open the test file for every exercise to check which file they need to create.

@hoovercj hoovercj changed the title Add stub exercise-name.ts files Add stub exercise-name.ts files to each exercise Aug 27, 2017
@masters3d
Copy link
Contributor

This is reasonable. We would also need to add a test to the CI to make sure all new exercises include a blank file.

@ghost
Copy link

ghost commented Sep 22, 2017

I've added the stubs files as well as a test for the CI in #65.

Ready for review.

@ghost
Copy link

ghost commented Sep 22, 2017

@hoovercj @masters3d Happy for this issue to be closed?

@hoovercj
Copy link
Author

I've only looked on my phone but it looks good. I really appreciate this, I think it adds the polish this track deserves. Thank you!

@masters3d
Copy link
Contributor

@BrianDGLS Thanks for the PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants