Show timeout status when test run channel doesn't respond in time #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kntsoriano
force-pushed
the
editor-timeout
branch
from
d1d3868
to
d64856f
Compare
iHiD
approved these changes
Oct 16, 2020
|
It might start to be interesting to extract all the hardcoded endpoints in the tests only to a single file, so changing the domain or a route is isolated to a single place. |
iHiD
pushed a commit
that referenced
this pull request
Oct 23, 2020
* Rewrite in-browser editor component * Use actual endpoints instead of stubbed endpoints * Timeout when test run channel does not respond in time (#195) * Pass solution ID in editor test * Only use isomorphic-fetch in test environment * Add accept header * Make textarea an uncontrolled component * Switch content to a function * Add TestRunChannel * Add JSON type checking * Cancel fetch when sending a new request and unmounting * Update app/javascript/utils/typecheck.ts Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info> * Move isomorphic-fetch to devDependencies * Downcase headers for compliance * Rename to onReceive Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.