Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all-your-base exercise #137

Merged
merged 2 commits into from Sep 26, 2016
Merged

Conversation

haus
Copy link
Contributor

@haus haus commented Sep 26, 2016

This commit adds the all-your-base exercise, with the tests ported from
the ruby version of the exercise.

This commit adds the all-your-base exercise, with the tests ported from
the ruby version of the exercise.
@yurrriq
Copy link
Member

yurrriq commented Sep 26, 2016

Hey, thanks! First, I think you'll need to rename all_your_base.clj to example.clj to get the tests passing. And then I think it'd be good to keep the function arguments on one line instead of one per argument, e.g.

[x y z]
;; instead of
[x
 y
 z]

@yurrriq
Copy link
Member

yurrriq commented Sep 26, 2016

The (->> ...) form in the :else clause of convert's cond looks misaligned, at least on mobile, so maybe double check that too and reindent as necessary.

This commit renames the src file to example.clj, moves all function
arguments to be on the same line and fixes the indentation in the ->>
form in convert.
@haus
Copy link
Contributor Author

haus commented Sep 26, 2016

Thanks for the quick feedback. I pushed out a commit that should resolve it. Happy to squash that into the previous commit if travis passes.

@yurrriq
Copy link
Member

yurrriq commented Sep 26, 2016

LGTM, thanks!

@yurrriq yurrriq merged commit 2568ad3 into exercism:master Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants