Improved linking to NUnit Test Adapter for Visual Studio for New-Project path #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #84
Issue Details:
The installation path for "Exercism.io Visual Studio Template" includes a template with NUnit 2.x framework, and correctly links to the NUnit 2.0 Test Adapter plugin for Visual Studio.
The alternative path "Create a New Visual Studio Project" suggests using nuget to install NUnit, which likely leads to an installation of the latest framework, version 3.x. Then there is no link/instruction to install the NUnit Test Adapter in this path, but I believe it is required because when I tested without, VS did not discover my tests. If the reader follows the link to Adapter 2.0 from the "Template" install path, they will get a mixed install: 3.x of framework, with 2.0 of Adapter. This results in still being unable to locate the tests in the Visual Studio Test Explorer window.
Fix:
This pull request adds a section to the "Create a New Visual Studio Project" path which explicitly links to multiple versions of the Adapter and warns that the major version number must agree between adapter and framework. This assertion is based on the description in the Adapter download page, which says, "NUnit 3 adapter for running tests in Visual Studio. Works with NUnit 3.x, use the NUnit 2 adapter for 2.x"
I feel a more complete fix would be to update the template to use v3.x of NUnit.