Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved linking to NUnit Test Adapter for Visual Studio for New-Project path #85

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Improved linking to NUnit Test Adapter for Visual Studio for New-Project path #85

merged 1 commit into from
Aug 26, 2016

Conversation

pckenney
Copy link
Contributor

Addresses issue #84

Issue Details:

The installation path for "Exercism.io Visual Studio Template" includes a template with NUnit 2.x framework, and correctly links to the NUnit 2.0 Test Adapter plugin for Visual Studio.

The alternative path "Create a New Visual Studio Project" suggests using nuget to install NUnit, which likely leads to an installation of the latest framework, version 3.x. Then there is no link/instruction to install the NUnit Test Adapter in this path, but I believe it is required because when I tested without, VS did not discover my tests. If the reader follows the link to Adapter 2.0 from the "Template" install path, they will get a mixed install: 3.x of framework, with 2.0 of Adapter. This results in still being unable to locate the tests in the Visual Studio Test Explorer window.

Fix:

This pull request adds a section to the "Create a New Visual Studio Project" path which explicitly links to multiple versions of the Adapter and warns that the major version number must agree between adapter and framework. This assertion is based on the description in the Adapter download page, which says, "NUnit 3 adapter for running tests in Visual Studio. Works with NUnit 3.x, use the NUnit 2 adapter for 2.x"

I feel a more complete fix would be to update the template to use v3.x of NUnit.

@ErikSchierboom ErikSchierboom merged commit a3e270b into exercism:master Aug 26, 2016
@ErikSchierboom
Copy link
Member

This is great! Thanks a lot. For a first PR you have done brilliantly, with a nice description of the problem and the fix. Much appreciated! 🎉

The Visual Studio template can be found here: https://github.com/rprouse/Exercism.VisualStudio, should you want to make another PR to modify that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants