feat: support unit test for examples && remove dev progress and it's port 4507 #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuigo
force-pushed
the
feat/unittest
branch
5 times, most recently
from
611db21
to
d673b7a
Compare
Closed
There is no need to listen extra dev port(4507). The reasons are as follows: 1. Port 4507 may be occupied by other process. 1. It's hard to run multile examples via `deno task dev`. 2. If we run `deno test example/*/server.test.ts`, it's to heavy to open/close a listen port 4507.
|
@deckchairlabs |
Yeah, sorry this is taking some time to get fixed. Work gets in the way sometimes! I'll have some time tomorrow to resolve the bug and this PR. |
|
hey @ahuigo I've resolved the failing test issues, could you fix the conflicts (looks simple enough) |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 features as following.
1. Support unit test for examples
2. Remove dev progress and it's port 4507
For #235
Ultra shares one port with App(default 8000)