Skip to content

Commit

Permalink
fix: make regroup similar results enhancer put button in a place that…
Browse files Browse the repository at this point in the history
… actually still exists (#113)
  • Loading branch information
dbjorge committed Oct 4, 2022
1 parent 817525b commit b020666
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 30 deletions.
2 changes: 1 addition & 1 deletion app/services/item-results/enhancers/regroup-similars.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export default class RegroupSimilars extends Service implements ItemResultsEnhan
buttonElement.dataset.state = 'hidden';
buttonElement.addEventListener('click', this.handleToggleClick.bind(this));

const detailsElement = result.querySelector('.details .pull-left');
const detailsElement = result.querySelector('.details .btns');
detailsElement?.appendChild(buttonElement);
}

Expand Down
1 change: 0 additions & 1 deletion app/styles/app.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

// Globals
@import 'globals/base';
@import 'globals/details-buttons';
@import 'globals/equivalent-pricings';
@import 'globals/header';
@import 'globals/highlight-stat-filters';
Expand Down
28 changes: 0 additions & 28 deletions app/styles/globals/_details-buttons.scss

This file was deleted.

1 change: 1 addition & 0 deletions changelogs/unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@

## Bug fixes 🐛

- Fixed "regroup similar results" button not appearing, which was completely hiding similar results. Thanks @poikende for reporting the issue ([#113](https://github.com/exile-center/better-trading/issues/113))!
- Fixed "equivalent pricing" currency icons looking squished when using the "default" (not "compact") trade view. Thanks @vvs for reporting the issue ([#114](https://github.com/exile-center/better-trading/issues/114))!

0 comments on commit b020666

Please sign in to comment.