Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added lookup for UID to name #17

Merged
merged 2 commits into from Feb 1, 2021
Merged

Added lookup for UID to name #17

merged 2 commits into from Feb 1, 2021

Conversation

karl-exini
Copy link

No description provided.

amorfis
amorfis approved these changes Jan 28, 2021
View reviewed changes
Copy link

@amorfis amorfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed tests for tagOf, maybe we could also have some for uidToName?

@karl-exini
Copy link
Author

I noticed tests for tagOf, maybe we could also have some for uidToName?

Good point - added.

@karl-exini karl-exini merged commit 85b386c into develop Feb 1, 2021
@karl-exini karl-exini deleted the feature/uid-to-name-lookup branch February 1, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorfis amorfis amorfis approved these changes

@fredrik-exini fredrik-exini fredrik-exini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@karl-exini @amorfis @fredrik-exini