Fix storage of repo.xml during package installation #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewiz
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Closes #3734.
This PR simply makes sure repo.xml is stored before post-install.xql is run, as documentation indicates it should be—instead of waiting to store repo.xml after post-install.xql, which makes it impossible to read from repo.xml to determine default permissions, etc.
Also, this PR adds to and, in some cases, corrects comments explaining the sequence of deployment—incrementally adding to our understanding of how deployment works and where it could be improved.
Reference:
Type of tests:
I tested this PR on my fix to the issue above, and confirmed that when applying this PR, a corresponding PR for the public-repo, eXist-db/public-repo#67, works perfectly.