fix(ci): add J16 and allow failures #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamretter
previously requested changes
Jun 10, 2021
There was a problem hiding this comment.
Thanks for discussing with me @duncdrum
As per our discussion, we must build the docs on J8 as I want to know that works before we get to "release time" and our release platform is Java 8. So if you can make that small change then I am happy to Merge
adamretter
reviewed
Jun 10, 2021
address review
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop J15, build and test on J16. Failures will not impact the overall result if they occur on J16 (yet).
Build javadocs on J11 and J16 both are failing, ignore all failures of doc building, we still get the news of whats wrong.
I dropped J8 from the docs, as these haven't been deployed anywhere from what i could tell, correct me if i m wrong.
supsersedes #3840