Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a different regression test suite #99

Closed
D4N opened this issue Oct 2, 2017 · 3 comments
Closed

Consider using a different regression test suite #99

D4N opened this issue Oct 2, 2017 · 3 comments
Labels
enhancement feature / functionality enhancements support Anything related to a user needing help with exiv2
Milestone

Comments

@D4N
Copy link
Member

D4N commented Oct 2, 2017

The current regression test script has some problems for managing it with git:

  1. The regressions are added into a single file
  2. The test results are added into a single binary file

Both make cherry-picking new commits onto old ones to backport changes quite cumbersome, especially the binary file, as git can't diff binary files. It would be a lot better if we would split the test file into lots of single files where each of them tests one single issue. This would make backporting very easy.

@clanmills
Copy link
Collaborator

Gosh, this could be tough. We should ensure that all "reference" files (such as bugfixes-test.out) is ascii. The main "culprit" here is bugfixes-test.sh which is monolithic monster. It would be better to have little scripts for every fix: bugfix-1234.sh with their own reference file bugfix-1234.out

So bugfixes-test.sh would drive individual scripts. Easy stuff. You can imagine why I've never given this priority.

@D4N
Copy link
Member Author

D4N commented Oct 3, 2017

I'll see if there is an easy way how to split the monolithic monster.

We could also try to use the unit test suite for regression tests.

@piponazo piponazo added the support Anything related to a user needing help with exiv2 label Oct 12, 2017
@D4N D4N added the enhancement feature / functionality enhancements label Oct 12, 2017
@D4N
Copy link
Member Author

D4N commented Jan 8, 2018

Fixed by #155.

@D4N D4N closed this as completed Jan 8, 2018
@clanmills clanmills added this to the v0.27 milestone Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature / functionality enhancements support Anything related to a user needing help with exiv2
Projects
None yet
Development

No branches or pull requests

3 participants